Adding 'Favorite' System to Pokemon Showdown: External Pull Request and Final Week of OSD600
Despite saying I wanted to work on a new repo for my final external pull request, after not being able to find a suitable issue, I ended up contributing to the Pokemon Showdown Client again. This time, I added an even larger feature than my last one: a 'favoriting' system that lets users quickly access users they play with frequently. The Issue Currently, the only way to match up with specific users on Pokemon Showdown is to either search them by username, or to find them in the chatrooms. However, the username search system requires an exact username, and turns up a result even if no user exists under that name. You'd only find out the account doesn't exist once you try to send a message or start a match. Opened chat even though user doesn't exist The Fix The solution I decided on was to allow users to 'Favorite' other users, allowing them to be quickly found later. Toggling favorite/unfavorite The first thing I did was add the '