Setting Up for Second External Pull Request and Contribution to Telescope

Our assignment for this week is the same as the assignment we had last week; to make a large contribution to one external project and to make a contribution to Telescope; our internal project. While I am still trying to decide on what issues I will tackle, I worked on a small fix for my contribution to Telescope from last week: spam-checker.js.

The Issue

In my last contribution, I created a spam checker that determined whether or no a post was spam using a combination of rules and a spam filter function. In my function, the blog post's body content was parsed before any of the checks were run, but if the blog's title was empty or marked as spam the body contents didn't need to be checked. A classmate suggested that I move the blog body parsing to after the title checks to save on resources if title checks failed and the body didn't need to be loaded.

The original order of checks, body is parsed before any checks are run

The Fix

After moving the content parsing after the title checks, I ran the tests to ensure everything was working as intended, then I created a pull request for my fix.

textParser moved after title checks

One issue I ran into while working on my fix was Eslint not liking the space between the function declaration and the parenthesis for the function arguments, but when I removed the space, VSCode would automatically add the space back in. I tried changing various VSCode settings regarding automatic formatting but none solved the issue, so I ended up editing the code with a text editor.

Removed the space between function and (content) with Notepad++

Choosing Internal and External Issues

As my fix is too small to count towards the assignment, I still need to find both an internal and external issue to work on. For my internal issue, I plan to work on implementing writing-level, as it seems that the previous assignees aren't working on it anymore. As for my external issue, I haven't decided on any repo yet, but I'd like t work on something other than Pokemon Showdown as my last two pull requests were for it.

Comments

Post a Comment

Popular posts from this blog

External Pull Request and Creating a Spam Checker for Telescope

Image
This week I was working on two projects: fixing an error with Pokemon Showdown's downloaded match replays, and creating a spam checker for Telescope Pokemon Showdown Client The Issue   Resume button appears under Play button on launch The external issue I worked on was preventing the Resume button from appearing behind the Play button when viewing a downloaded replay from Pokemon Showdown: something I thought would be more complex than it ended up being, having worked with Pokemon Showdown before. The Fix After finding the class I had to work on, replay-embed.js,  I had to figure out how downloaded replays worked with replay-embed. While waiting for a response from Zarel, I tried generating a replay using my cloned version for Pokemon Showdown Client to no avail. Eventually, I learned from Zarel that the replay file has to be edited so that the script source points to my version of replay-embed. I changed the path to the filepath to my copy of replay-embed, but the bat
Read more

Second Contribution of Hacktoberfest

Image
For the second week of Hacktoberfest, I contributed to Fast Read , a React App created by Hamzaolak. The Fast Read Application The Issue   As I was having issues with the other projects I was planning to work on, I settled on another simple fix; changing the names of the custom colors defined in the code. The Fix After finding the color definitions, all I had to do was change the names in the definitions, as well as in the files that use those colors. The color names being in the issue description was helpful, especially with them being in the same order as the original colors. Creating the Pull Request After confirming that everything works as intended, I switched the origin remote to my forked version of the repo. Then I created a new branch and pushed my commit to it. Finally, I created a pull request to merge my code into the original project. Issues and Lessons Learned While searching for projects to contribute to for this week, I noticed many
Read more

Adding 'Favorite' System to Pokemon Showdown: External Pull Request and Final Week of OSD600

Image
Despite saying I wanted to work on a new repo for my final external pull request, after not being able to find a suitable issue, I ended up contributing to the Pokemon Showdown Client again. This time, I added an even larger feature than my last one: a 'favoriting' system that lets users quickly access users they play with frequently. The Issue Currently, the only way to match up with specific users on Pokemon Showdown is to either search them by username, or to find them in the chatrooms. However, the username search system requires an exact username, and turns up a result even if no user exists under that name. You'd only find out the account doesn't exist once you try to send a message or start a match. Opened chat even though user doesn't exist The Fix The solution I decided on was to allow users to 'Favorite' other users, allowing them to be quickly found later. Toggling favorite/unfavorite The first thing I did was add the '
Read more